R11/release11-tools
4
2
Fork 0
Code Issues 9 Pull Requests 4 Packages Projects Releases 6 Wiki Activity

Added backend support for multiple files in XSLT. #272

Merged
bema merged 15 commits from widlam/add_multiplefiles_xslt into master 2023-12-04 06:59:06 +01:00
Conversation 7 Commits 15 Files Changed 9 +262 -3
widlam commented 2023-12-01 12:20:38 +01:00
Collaborator
Copy Link
No description provided.
widlam added 14 commits 2023-12-01 12:20:39 +01:00
Changed process to processorData in app 1f98e9db1e
Updated Swagger 0694cda5b0
Updated tests f352e60db6
Updated samples 34f2b59c6e
Changed process to processorData in app 87b9bfafc6
Updated Swagger 212444fd5c
Updated tests 630480fef3
Updated samples 3ac1fbe49d
Merge branch 'ref/process_name_change' of gitea.release11.com:R11/release11-tools into ref/process_name_change a8f2106a53
Fixed libxml backend bf34cca6d6
implement backend endpoints and file creating logic for processing multiple XMLs with XSLT e3a53d1340
semi implemented 6607f20d78
Finished backend feature and cleans code a5f9b31f4e
Merge branch 'master' of gitea.release11.com:R11/release11-tools into widlam/add_multiplefiles_xslt 8f9e1f7b7a
widlam requested review from bema 2023-12-01 12:20:45 +01:00
bema changed title from Added backend support for multiple files in XSLT. to WIP: Added backend support for multiple files in XSLT. 2023-12-01 13:15:31 +01:00
bema reviewed 2023-12-01 13:24:38 +01:00
Backend/tools-services/src/main/java/com/r11/tools/controller/XmlController.java Outdated
@@ -2,6 +2,7 @@ package com.r11.tools.controller;
import com.google.gson.Gson;
import com.r11.tools.controller.internal.*;
import com.r11.tools.model.XMLMultipleFilesBody;
bema commented 2023-12-01 13:24:38 +01:00
Collaborator
Copy Link

This is unneeded, so should be removed

This is unneeded, so should be removed
bema reviewed 2023-12-01 13:25:47 +01:00
Backend/tools-services/src/main/java/com/r11/tools/controller/internal/MultipleXmlJob.java
@@ -0,0 +1,38 @@
package com.r11.tools.controller.internal;
import com.r11.tools.model.XMLMultipleFilesBody;
import com.r11.tools.model.XMLRequestBody;
bema commented 2023-12-01 13:25:47 +01:00
Collaborator
Copy Link

Unused import, removal needed

Unused import, removal needed
bema reviewed 2023-12-01 13:25:57 +01:00
Backend/tools-services/src/main/java/com/r11/tools/controller/internal/MultipleXmlJob.java
@@ -0,0 +2,4 @@
import com.r11.tools.model.XMLMultipleFilesBody;
import com.r11.tools.model.XMLRequestBody;
import com.r11.tools.xml.Saxon;
bema commented 2023-12-01 13:25:57 +01:00
Collaborator
Copy Link

Same as above

Same as above
bema reviewed 2023-12-01 13:30:54 +01:00
Backend/tools-services/src/main/java/com/r11/tools/xml/Saxon.java Outdated
@@ -16,0 +25,4 @@
* @return transformed xml
* @throws SaxonApiException thrown on stylesheet or transformation error
*/
public String processXSLT(XMLMultipleFilesData[] data, String transform) throws SaxonApiException, IOException{
bema commented 2023-12-01 13:30:54 +01:00
Collaborator
Copy Link

I would extract some parts of the code from this method to separate private methods to increase readability

I would extract some parts of the code from this method to separate private methods to increase readability
bema reviewed 2023-12-01 13:33:38 +01:00
Frontend/src/components/xml/XmlOutputFieldComponent.vue
@@ -108,6 +108,7 @@ function prepareRequestBody():string {
"processor": engine.value,
"version": version.value
});
console.log(requestBody)
bema commented 2023-12-01 13:33:38 +01:00
Collaborator
Copy Link

We should left console.logs like this in production code as it serves no purpose, altough I understand that can happen ;)

We should left console.logs like this in production code as it serves no purpose, altough I understand that can happen ;)
bema requested changes 2023-12-01 13:39:34 +01:00
bema left a comment
Collaborator
Copy Link

There are some minor things to correct, like unused imports and one method that requires splitting. However, this change is made well overall.

There are some minor things to correct, like unused imports and one method that requires splitting. However, this change is made well overall.
widlam added 1 commit 2023-12-01 14:21:52 +01:00
Fixed problem, and cleans code 2843d0560a
bema changed title from WIP: Added backend support for multiple files in XSLT. to Added backend support for multiple files in XSLT. 2023-12-04 06:57:56 +01:00
bema approved these changes 2023-12-04 06:58:31 +01:00
bema merged commit 6f2d16c2b9 into master 2023-12-04 06:59:06 +01:00
bema deleted branch widlam/add_multiplefiles_xslt 2023-12-04 06:59:06 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
bema
Labels
Clear labels
JSON Formatter
Regarding JSON Formatter tool
REST Mock
Regarding REST Mock Services tool
Spike
Something to brainstorm
XML Formatter
Regarding XML Formatter tool
XPath
Regarding XPath tool
XQuery
Regarding XQueryr tool
XSD
Regarding XSD tool
XSLT
Regarding XSLT tool
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
high priority
maintenence/refactor
Things that don't implement new functionality or fix bugs, but help keeping codebase clean
medium priority
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
administrator bartosz bema boguckib dudzikp koleckia szewczyw widlam
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: R11/release11-tools#272
No description provided.
Delete Branch "widlam/add_multiplefiles_xslt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?