widlam/dev/implement_rest_mock #231

Merged
bema merged 8 commits from widlam/dev/implement_rest_mock into master 2023-06-22 14:11:51 +02:00
Collaborator
No description provided.
widlam added 2 commits 2023-06-19 15:50:24 +02:00
Implemented basic structure for mock service
Added dev.sh script to run r11-tools in dev-mode with hot-reload for frontend
bema added 1 commit 2023-06-20 12:18:31 +02:00
widlam added 3 commits 2023-06-22 10:27:42 +02:00
widlam requested review from bema 2023-06-22 10:28:04 +02:00
Collaborator

So far I found a few things that need to be corrected:

  • Popup doesn't automatically close after some time
  • When I put some header like this:

obraz

It's not send in response until I add second header using plus button. I suggest one of two solutions:

  1. Disable last text fields to block user from putting data into nonexistent header
  2. Remove '+' and 'X' buttons altogether and add/remove headers depending on condition that both it's value and name are blank.
  • When I post something with long header, the header table gets misaligned

obraz

  • Very long request body gets of page

obraz

  • Same with very long headers

I can take care of last two when I will be finishing styling of whole tool.

So far I found a few things that need to be corrected: - Popup doesn't automatically close after some time - When I put some header like this: ![obraz](/attachments/f1cfcb92-a37a-4b59-b81c-8ac977208b3f) It's not send in response until I add second header using plus button. I suggest one of two solutions: 1. Disable last text fields to block user from putting data into nonexistent header 2. Remove '+' and 'X' buttons altogether and add/remove headers depending on condition that both it's value and name are blank. - When I post something with long header, the header table gets misaligned ![obraz](/attachments/555c525b-86a3-49bd-9e2a-097b6d7a4a05) - Very long request body gets of page ![obraz](/attachments/c56a05a3-dbd1-4ae0-8623-b3513b54f7af) - Same with very long headers I can take care of last two when I will be finishing styling of whole tool.
bema requested changes 2023-06-22 10:55:13 +02:00
bema left a comment
Collaborator

I've listed things I suggest changing in seperate comment.

I've listed things I suggest changing in seperate comment.
widlam added 1 commit 2023-06-22 13:54:36 +02:00
bema added 1 commit 2023-06-22 14:10:26 +02:00
bema approved these changes 2023-06-22 14:11:16 +02:00
bema changed title from WIP: widlam/dev/implement_rest_mock to widlam/dev/implement_rest_mock 2023-06-22 14:11:26 +02:00
bema merged commit 395ca6817d into master 2023-06-22 14:11:51 +02:00
bema referenced this issue from a commit 2023-06-22 14:11:51 +02:00
bema deleted branch widlam/dev/implement_rest_mock 2023-06-22 14:11:52 +02:00
Sign in to join this conversation.
No description provided.