Refactor of History module #184

widlam · 2023-05-11T14:01:49+02:00

widlam commented

2023-05-11 14:01:49 +02:00

No description provided.

widlam added 3 commits 2023-05-11 14:01:51 +02:00

Changed history module 0fee9192f4

Updated Spring Boot version to 2.7.11
Fixed Loombok to cooperate with Mapstruct

Merge branch 'master' of gitea.release11.com:R11/release11-tools into widlam/refactor/issue#162 62cc2fb140

Added request body to history entity and DTO. 37729aba8b

Changed @GetMapping in MockController to @RequestMapping

bema changed title from ~~WIP: Refactor od History module~~ to WIP: Refactor of History module

2023-05-11 15:25:16 +02:00

widlam added 5 commits 2023-05-15 11:11:06 +02:00

Tools java backend now uses interfaces for engine classes (solves #167 ) (#179 ) 34038a2ce9

Co-authored-by: Adam Bem <adam.bem@zoho.eu>
Reviewed-on: #179
Reviewed-by: Mikolaj Widla <widlam@noreply.example.com>

ddd 95cde1eed9

Moved frontend of REST Mock to frontend container (solves #168 ) dc3df79fc1

Co-authored-by: Adam Bem <adam.bem@zoho.eu>
Reviewed-on: #186
Reviewed-by: Mikolaj Widla <widlam@noreply.example.com>

Merge branch 'master' of gitea.release11.com:R11/release11-tools into widlam/refactor/issue#162 cc6c2945e1

Changed retention f94ad35bc0

widlam added 4 commits 2023-05-17 11:05:26 +02:00

Merge branch 'master' of gitea.release11.com:R11/release11-tools into widlam/refactor/issue#162 80cab379c8

started to making view of history on frontend 720eed2a73

Improve adding headers to frontend 12f1e04487

Finished adding backend features to frontend 3d84e513fa

widlam added 2 commits 2023-05-17 12:02:38 +02:00

Merge branch 'master' of gitea.release11.com:R11/release11-tools into widlam/refactor/issue#162 4aa1da0669

Improved frontend a411613f27

widlam requested review from bema 2023-05-17 12:02:58 +02:00

bema commented

2023-05-17 12:21:01 +02:00

After quick testing I found some things to fix:

Table doesn't fill whole popup window when there are short headers. IMO popup width is correct, so I would just widen the table.
When long header is put, the popup becomes too wide and doesn't fit in the window.
Timestamps should be more readable.
Those debug console.logs also need to be removed
Refresh button doesn't spin exactly around it's middle point, so the button "wobbles" a little bit

After quick testing I found some things to fix: - Table doesn't fill whole popup window when there are short headers. IMO popup width is correct, so I would just widen the table. ![image](/attachments/4a4cefc0-0687-43cf-99db-3adf47a7d061) - When long header is put, the popup becomes too wide and doesn't fit in the window. ![image](/attachments/97e08ba6-5502-46a8-a837-5f53df0f634b) - Timestamps should be more readable. - Those debug console.logs also need to be removed ![image](/attachments/d4c12873-8f40-4bfb-b0e1-61cbcc167b53) - Refresh button doesn't spin exactly around it's middle point, so the button "wobbles" a little bit

image.png

158 KiB

image.png

49 KiB

image.png

259 KiB

image.png

200 KiB

bema requested changes 2023-05-17 14:30:17 +02:00

bema left a comment

Brakuje docsów w nowych klasach:

RetencionConfiguration,
RetencionConfigurationProperties (chociaż tu bym sobie darował, nazwa mówi sama za siebie)
WebConfig
HistoryRequest
RequestHistoryMapper

Brakuje docsów w nowych klasach: - RetencionConfiguration, - RetencionConfigurationProperties (chociaż tu bym sobie darował, nazwa mówi sama za siebie) - WebConfig - HistoryRequest - RequestHistoryMapper

bema added 1 commit 2023-05-17 14:37:33 +02:00

Removed lonely 'f' a2e472e647

widlam added 2 commits 2023-05-18 14:06:41 +02:00

Added request body 1f5087b929

Merge branch 'widlam/refactor/issue#162' of gitea.release11.com:R11/release11-tools into widlam/refactor/issue#162 f25d8f0e7e

bema added 1 commit 2023-05-18 15:05:48 +02:00

XML request bodies are now formatted 92df5abf9c

bema added 1 commit 2023-05-18 15:29:48 +02:00

Cleand up XML code 081ce03d38

bema added 1 commit 2023-05-18 15:45:22 +02:00

Fixed loading of request bodies 80d3c708dd

bema added 2 commits 2023-05-18 15:54:28 +02:00