widlam/refactor/issue#132 #139

Merged
bema merged 10 commits from widlam/refactor/issue#132 into master 2023-04-18 10:05:46 +02:00
Collaborator
No description provided.
widlam added 6 commits 2023-04-14 10:20:37 +02:00
widlam added 2 commits 2023-04-14 11:09:55 +02:00
bema requested review from augustyd 2023-04-14 11:11:10 +02:00
bema requested review from bema 2023-04-14 11:11:10 +02:00
bema requested changes 2023-04-14 12:40:12 +02:00
bema left a comment
Collaborator

I would change only one small thing:

Semantics legend:

I would make this header, well, a header, ex. h4, or pick it out in some other way.

I would change only one small thing: > Semantics legend: I would make this header, well, a header, ex. h4, or pick it out in some other way.
widlam added 1 commit 2023-04-14 13:49:01 +02:00
widlam requested review from bema 2023-04-14 13:49:04 +02:00
bema requested changes 2023-04-14 14:36:03 +02:00
bema left a comment
Collaborator

I found some missing and one doubled function in XPath 3.1:

  • collation-key
  • element-with-id
  • contains-token
  • default-language
  • sort
  • apply
  • load-xquery-module
  • parse-json
  • json-doc
  • json-to-xml
  • xml-to-json

Doubled:

  • adjust-date-to-timezone

In XPath 3.0 I found one missing function (element-with-id) and one doubled (adjust-date-to-timezone).

I found some missing and one doubled function in XPath 3.1: * collation-key * element-with-id * contains-token * default-language * sort * apply * load-xquery-module * parse-json * json-doc * json-to-xml * xml-to-json Doubled: * adjust-date-to-timezone In XPath 3.0 I found one missing function (element-with-id) and one doubled (adjust-date-to-timezone).
widlam added 1 commit 2023-04-17 10:30:09 +02:00
added missing functions for XPath 3.1
widlam requested review from bema 2023-04-17 10:45:03 +02:00
bema approved these changes 2023-04-18 10:01:30 +02:00
bema left a comment
Collaborator

Git gut

Git gut
augustyd approved these changes 2023-04-18 10:03:25 +02:00
augustyd left a comment
Contributor

small change, does not need comment

small change, does not need comment
widlam changed title from WIP: widlam/refactor/issue#132 to widlam/refactor/issue#132 2023-04-18 10:04:10 +02:00
bema changed title from widlam/refactor/issue#132 to widlam/refactor/issue#132 2023-04-18 10:04:29 +02:00
bema merged commit 8098aeacd9 into master 2023-04-18 10:05:46 +02:00
bema deleted branch widlam/refactor/issue#132 2023-04-18 10:05:46 +02:00
Sign in to join this conversation.
No description provided.